Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Fri, 25 Mar 2011 14:45:05 +0000 (UTC)
From: "Knut Anders Hatlen (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: 
 <381647570.11364.1301064305679.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1464914770.9935.1297409337558.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Resolved] (DERBY-5021) [patch] avoid map look ups in a loop
 by using entrySet
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-5021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen resolved DERBY-5021.
---------------------------------------

          Resolution: Fixed
            Assignee: Dave Brosius
    Issue & fix info:   (was: [Patch Available])

After DERBY-5143 we don't need the changes in EmbedConnection40 and NetConnection40 that reintroduced the compiler warnings. I removed the changes in those two files from the patch and committed revision 1085409. Thanks, Dave!

> [patch] avoid map look ups in a loop by using entrySet
> ------------------------------------------------------
>
>                 Key: DERBY-5021
>                 URL: https://issues.apache.org/jira/browse/DERBY-5021
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 10.8.0.0
>
>         Attachments: use_entryset_iterators.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> various places code walks a keyset iterator in a loop and each time thru the loop does a map lookup for the value based on the current key. Avoid the map look ups by just iterating with an entry set iterator.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira