Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 58142 invoked from network); 30 Mar 2011 19:56:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 30 Mar 2011 19:56:45 -0000 Received: (qmail 70218 invoked by uid 500); 30 Mar 2011 19:56:45 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 70185 invoked by uid 500); 30 Mar 2011 19:56:45 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 70178 invoked by uid 99); 30 Mar 2011 19:56:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Mar 2011 19:56:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Mar 2011 19:56:43 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id B9EB08A0C2 for ; Wed, 30 Mar 2011 19:56:05 +0000 (UTC) Date: Wed, 30 Mar 2011 19:56:05 +0000 (UTC) From: "Kathey Marsden (JIRA)" To: derby-dev@db.apache.org Message-ID: <1974193252.22008.1301514965758.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1227676784.8231.1299086146182.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (DERBY-5084) convert ijConnName.sql to a ScriptTest junit test MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013617#comment-13013617 ] Kathey Marsden commented on DERBY-5084: --------------------------------------- Well, one thing to consider is that neither of these cases were actually tested with the old test because it had in the ijConnName_sed.properties: -- delete=ERROR 08001:*,ERROR XJ004:* but both are perfectly valid cases that should be tested. So I would say for the converted ijConnName test, keep the property ij.connection.connFour=jdbc:derby:nevercreated and test that case. For ij.connection.connThree=jdbc:noone:fruitfly;create=true , since the JVM messages differ I think we will need to think of a different way to test that one outside of the master based ScriptTestCase. I don't think it would be a major loss now with the conversion of this test as we are currrently deleting both these lines when run in the old harness. > convert ijConnName.sql to a ScriptTest junit test > ------------------------------------------------- > > Key: DERBY-5084 > URL: https://issues.apache.org/jira/browse/DERBY-5084 > Project: Derby > Issue Type: Improvement > Components: Test > Reporter: Myrna van Lunteren > Assignee: Houx Zhang > Priority: Trivial > Labels: derby_triage10_8 > Attachments: DERBY-5084-1.patch, DERBY-5084-2.patch, DERBY-5084-3.patch, DERBY-5084-3.stat, DERBY-5084.patch, DERBY-5084_4.diff, ijConnName-1.out, ijConnName-1.tmp > > > In DERBY-3089 it is mentioned that tools/ijConnName.sql should get converted to a junit test, probably using ScriptTest. > Making a separate issue so that that issue can be closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira