db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Houx Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-4260) Make derbynet/NetworkServerControlClientCommandTest run regardless of the locale
Date Sun, 27 Mar 2011 04:55:05 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Houx Zhang updated DERBY-4260:
------------------------------

    Attachment: 4260-1.patch

In my testing on NetworkServerControlClientCommandTest.testPing(), it's useless to use LocaleTestSetup.
The assertExecJavaCmdAsExpected() runs in a separate process. 

In my patch, "-Dderby.ui.locale=en_US" has been included in command args, and the testcase
passed in Chinese Platform, while failed when reverted into default state.

Furthermore, as the old testcase tests five situations in just one function testPing(), I
have splitted it into five funcstions to make it more readable and maintainable.

Wish for your comments, thanks!

> Make derbynet/NetworkServerControlClientCommandTest run regardless of the locale
> --------------------------------------------------------------------------------
>
>                 Key: DERBY-4260
>                 URL: https://issues.apache.org/jira/browse/DERBY-4260
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.6.1.0
>            Reporter: Tiago R. Espinha
>            Assignee: Houx Zhang
>            Priority: Minor
>         Attachments: 4260-1.patch
>
>
> The NetworkServerControlClientCommandTest has in it a check that will only run the test
if the locale is set to 'en'.
> It is open to suggestion the how to achieve this and whether it should be done. Since
the test is a pretty generic one, I think it should be ran regardless of the locale.
> Knut suggested we'd force the locale to 'en' on the setUp() and back to its previous
value on the tearDown(). On a first analysis this seems like the ideal method to go about
it. Just removing the check for the locale altogether might not be wise because of the calls
to assertFailedPing() that involve some hardcoded strings.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message