db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Houx Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-5084) convert ijConnName.sql to a ScriptTest junit test
Date Sun, 27 Mar 2011 11:47:06 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Houx Zhang updated DERBY-5084:
------------------------------

    Attachment: DERBY-5084-3.patch
                DERBY-5084-3.stat

Myrna, thanks very much for your detailed insctruction, it's valuale to me.

Following your advice, I have finished DERBY-5084-3.patch. In it, removal of the lemming database
is resolved well, and SystemPropertySetUp is used to perform the original aim in ijConnName_app.properties.
In the beginning of the .sql script, I added:

---disconnect connection created by ScriptTestCase 
show connections;
disconnect CONNECTION0;
set connection connOne; 

I suppose, CONNECTION0(wombat) is created by the Derby JUnit framework, our connOne connected
to the same database in fact, so "disconnect CONNECTION0" and "set connection connOne" can
give a clear view.


Please check the patch, thanks!

Besides, if drop a temporary database is common, why not extract out a util class to do this?
Maybe a new issue can be created to deal with it. There is already DropDatabaseSetup which
can do this, but it's not visible, and just able to remove a specially named database.

Regards

> convert ijConnName.sql to a ScriptTest junit test
> -------------------------------------------------
>
>                 Key: DERBY-5084
>                 URL: https://issues.apache.org/jira/browse/DERBY-5084
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Myrna van Lunteren
>            Priority: Trivial
>              Labels: derby_triage10_8
>         Attachments: DERBY-5084-1.patch, DERBY-5084-2.patch, DERBY-5084-3.patch, DERBY-5084-3.stat,
DERBY-5084.patch, ijConnName-1.out, ijConnName-1.tmp
>
>
> In DERBY-3089 it is mentioned that tools/ijConnName.sql should get converted to a junit
test, probably using ScriptTest.
> Making a separate issue so that that issue can be closed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message