db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-4260) Make derbynet/NetworkServerControlClientCommandTest run regardless of the locale
Date Sun, 27 Mar 2011 16:25:05 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011818#comment-13011818
] 

Bryan Pendleton commented on DERBY-4260:
----------------------------------------

Is it necessary to split the testPing test up as part of this? It seems like it would be
a simpler patch if we just addressed the locale issue for now.

> Make derbynet/NetworkServerControlClientCommandTest run regardless of the locale
> --------------------------------------------------------------------------------
>
>                 Key: DERBY-4260
>                 URL: https://issues.apache.org/jira/browse/DERBY-4260
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.6.1.0
>            Reporter: Tiago R. Espinha
>            Assignee: Houx Zhang
>            Priority: Minor
>              Labels: gsoc, gsoc2011
>         Attachments: 4260-1.patch
>
>
> The NetworkServerControlClientCommandTest has in it a check that will only run the test
if the locale is set to 'en'.
> It is open to suggestion the how to achieve this and whether it should be done. Since
the test is a pretty generic one, I think it should be ran regardless of the locale.
> Knut suggested we'd force the locale to 'en' on the setUp() and back to its previous
value on the tearDown(). On a first analysis this seems like the ideal method to go about
it. Just removing the check for the locale altogether might not be wise because of the calls
to assertFailedPing() that involve some hardcoded strings.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message