Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 68883 invoked from network); 12 Feb 2011 16:05:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Feb 2011 16:05:26 -0000 Received: (qmail 37062 invoked by uid 500); 12 Feb 2011 16:05:26 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 36532 invoked by uid 500); 12 Feb 2011 16:05:24 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 36303 invoked by uid 99); 12 Feb 2011 16:05:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Feb 2011 16:05:20 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Feb 2011 16:05:18 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id BDC2B1A108E for ; Sat, 12 Feb 2011 16:04:57 +0000 (UTC) Date: Sat, 12 Feb 2011 16:04:57 +0000 (UTC) From: "Bryan Pendleton (JIRA)" To: derby-dev@db.apache.org Message-ID: <88698134.13023.1297526697773.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <88531150.9965.1297410177653.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] Commented: (DERBY-5022) [patch] override equals correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993944#comment-12993944 ] Bryan Pendleton commented on DERBY-5022: ---------------------------------------- I think maybe you should leave "Patch available" checked, as the patch is still available, though it's clearly not ready for commit as is. Your observations about the behavior changes that are caused by the patch are important to record; can you attach any information about the test failures? Can you briefly summarize the behavior that was altered by the patch? Do you have any theories about how the patch caused these changes in behavior? > [patch] override equals correctly > --------------------------------- > > Key: DERBY-5022 > URL: https://issues.apache.org/jira/browse/DERBY-5022 > Project: Derby > Issue Type: Bug > Components: Network Server > Affects Versions: 10.7.1.1 > Reporter: Dave Brosius > Priority: Minor > Fix For: 10.8.0.0 > > Attachments: override_equals_correctly.diff, test.tgz > > Original Estimate: 1h > Remaining Estimate: 1h > > code implements equals w/o an Object parm. Calling code that doesn't have first class signature of FormatableBitSet will not work as expected. Properly override equals to fix. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira