Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Fri, 11 Feb 2011 11:43:57 +0000 (UTC)
From: "Knut Anders Hatlen (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: 
 <1440110903.10345.1297424637454.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <267495482.9914.1297408559696.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] Resolved: (DERBY-5020) [patch] remove redundant finalizer
 methods
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen resolved DERBY-5020.
---------------------------------------

          Resolution: Fixed
            Assignee: Dave Brosius
    Issue & fix info:   (was: [Patch Available])

We did see some performance issues on the embedded driver before that were caused by EmbedResultSet overriding finalize(), so I think this would be good to get fixed. Thanks, Dave!

Committed revision 1069760.

> [patch] remove redundant finalizer methods
> ------------------------------------------
>
>                 Key: DERBY-5020
>                 URL: https://issues.apache.org/jira/browse/DERBY-5020
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 10.8.0.0
>
>         Attachments: remove_redundant_finalizers.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> code implements a finalize method by just calling super.finalize. Having a finalizer makes the work of the gc harder than if you didn't have it at all, so remove it.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira