Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Thu, 24 Feb 2011 00:05:38 +0000 (UTC)
From: "Dag H. Wanvik (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: 
 <1254385313.12175.1298505938598.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] Issue Comment Edited: (DERBY-4741) Make embedded Derby work
 reliably in the presence of thread interrupts
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/DERBY-4741?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1299=
8620#comment-12998620 ]=20

Dag H. Wanvik edited comment on DERBY-4741 at 2/24/11 12:05 AM:
----------------------------------------------------------------

Uploading a patch which reintroduces the fix that was backed out with chang=
es to the build. Essentially it moves the compilation of MBeans out till af=
ter the iapis have been built. Thanks to Knut for pinpointing the feact tha=
t compilation of MBeans depends on Monitor, but is in fact compiled before =
the iapi currently. Setting the sourcepath for javac to "" for mbeans-compi=
le highlighted the issue, cf this comment: https://issues.apache.org/jira/b=
rowse/DERBY-4845?page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:com=
ment-tabpanel&focusedCommentId=3D12998479#comment-12998479

Still,exactly why this makes it compile with explicit setting of jsr169comp=
ile.classpath now, whereas it did not before, is still a bit unclear to me.=
 It seems to work now, though. Running regressions.


      was (Author: dagw):
    Uploading a patch which reintroduces the fix that was backed out with c=
hanges to the build. Essentially it moves the compilation of MBeans out til=
l after the iapis have been built. Thanks to Knut for pinpointing the feact=
 that compilation of MBeans depends on Monitor, but is in fact compiled bef=
ore the iapi currently. Setting the sourcepath for javac to "" for mbeans-c=
ompile highlighted the issue.

Still,exactly why this makes it compile with explicit setting of jsr169comp=
ile.classpath now, whereas it did not before, is still a bit unclear to me.=
 It seems to work now, though. Running regressions.

 =20
> Make embedded Derby work reliably in the presence of thread interrupts
> ----------------------------------------------------------------------
>
>                 Key: DERBY-4741
>                 URL: https://issues.apache.org/jira/browse/DERBY-4741
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.2.1.6, 10.2.2.0, 10.3.1.4, 10.3.2.1, 10.3.3.0, 10=
.4.1.3, 10.4.2.0, 10.5.1.1, 10.5.2.0, 10.5.3.0, 10.6.1.0
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>              Labels: derby_triage10_8
>         Attachments: InterruptResilienceTest.java, MicroAPITest.java, der=
by-4741-a-01-api-interruptstatus.diff, derby-4741-a-01-api-interruptstatus.=
stat, derby-4741-a-02-api-interruptstatus.diff, derby-4741-a-02-api-interru=
ptstatus.stat, derby-4741-a-03-api-interruptstatus.diff, derby-4741-a-03-ap=
i-interruptstatus.stat, derby-4741-a-04-api-interruptstatus.diff, derby-474=
1-a-04-api-interruptstatus.stat, derby-4741-all+lenient+resurrect.diff, der=
by-4741-all+lenient+resurrect.stat, derby-4741-b-01-nio.diff, derby-4741-b-=
01-nio.stat, derby-4741-b-02-nio.diff, derby-4741-b-02-nio.stat, derby-4741=
-b-03-nio.diff, derby-4741-b-03-nio.stat, derby-4741-b-04-nio.diff, derby-4=
741-b-04-nio.stat, derby-4741-c-01-nio.diff, derby-4741-c-01-nio.stat, derb=
y-4741-fix-compilation.diff, derby-4741-fix-compilation.stat, derby-4741-kr=
istians-01.diff, derby-4741-nio-container+log+waits+locks+throws.diff, derb=
y-4741-nio-container+log+waits+locks+throws.stat, derby-4741-nio-container+=
log+waits+locks-2.diff, derby-4741-nio-container+log+waits+locks-2.stat, de=
rby-4741-nio-container+log+waits+locks.diff, derby-4741-nio-container+log+w=
aits+locks.stat, derby-4741-nio-container+log+waits.diff, derby-4741-nio-co=
ntainer+log+waits.stat, derby-4741-nio-container+log.diff, derby-4741-nio-c=
ontainer+log.stat, derby-4741-nio-container-2.diff, derby-4741-nio-containe=
r-2.log, derby-4741-nio-container-2.stat, derby-4741-nio-container-2b.diff,=
 derby-4741-nio-container-2b.stat, derby-4741-raf-stresstest-1.diff, derby-=
4741-raf-stresstest-1.stat, derby-4741-raf-stresstest-2.diff, derby-4741-ra=
f-stresstest-2.stat, derby-4741-raf-stresstest-3.diff, derby-4741-raf-stres=
stest-3.stat, derby-4741-raf-stresstest-4.diff, derby-4741-raf-stresstest-4=
.stat, derby-4741-sleeps-waits-1.diff, derby-4741-sleeps-waits-1.stat, derb=
y-4741-sleeps-waits-2.diff, derby-4741-sleeps-waits-2.stat, derby-4741-slee=
ps-waits-3.diff, derby-4741-sleeps-waits-3.stat, derby-4741-sleeps-waits-mo=
re.diff, derby-4741-sleeps-waits-more.stat, derby-4741-testBatchInterrupt-b=
.diff, derby-4741-testBatchInterrupt.diff, derby-4741-testQueryInterrupt.di=
ff, derby-4741-testQueryInterrupt.stat, derby.log, derby.log, interrupts-fs=
.html, interrupts-fs.html, interrupts-fs.html, interrupts-fs.html, sleep-1-=
usages.txt, wait-0-usages.txt, wait-1-usages.txt, xsbt0.log.gz
>
>
> When not executing on a small device VM, Derby has been using the Java NI=
O classes java.nio.clannel.* for file io for extra concurrency.
> If a thread is interrupted while executing blocking IO operations in NIO,=
 the ClosedByInterruptException will get thrown. Unfortunately, Derby isn't=
 current architected to retry and complete such operations (before passing =
on the interrupt), so the Derby database store can be left in an inconsiste=
nt state, although no data is corrupted, and we therefore have to return a =
database level error to perform shutdown and recovery. This means the appli=
cations can no longer access the database while a shutdown and reboot inclu=
ding a recovery is taking place.
> It would be nice if Derby could somehow detect and finish IO operations u=
nderway when thread interrupts happen before passing the exception on to th=
e application. Derby embedded is sometimes embedded in applications that us=
e Thread.interrupt to stop threads.

--=20
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira