db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-5036) [patch] fix impossible comparison due to sign extension
Date Mon, 14 Feb 2011 20:06:57 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994461#comment-12994461
] 

Knut Anders Hatlen commented on DERBY-5036:
-------------------------------------------

Looks like a bug, yes. Thanks! I'll check in the fix.

It looks to me like the client driver never passes a TRGDFTRT parameter to the server, so
this code doesn't appear to be in use. Does anyone know if support for this codepoint is needed
for JCC? (Probably not, otherwise our tests should have detected that the code didn't work
back when most of the client/server testing happened against both JCC and the Derby Network
Client.) Maybe we should use this opportunity to get rid of some unused and untested code?

> [patch] fix impossible comparison due to sign extension
> -------------------------------------------------------
>
>                 Key: DERBY-5036
>                 URL: https://issues.apache.org/jira/browse/DERBY-5036
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Server
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Priority: Minor
>             Fix For: 10.8.0.0
>
>         Attachments: bad_byte_compare.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> code does 
> 	byte b = reader.readByte();
> 	if (b == 0xF1)
> 		database.sendTRGDFTRT = true;
> due to sign extension, this test will never be true.
> fixed

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message