db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kathey Marsden <kmarsdende...@sbcglobal.net>
Subject Re: [jira] Commented: (DERBY-5055) [patch] add visibility to static method calls
Date Fri, 18 Feb 2011 17:25:46 GMT
On 2/18/2011 8:43 AM, Dave Brosius (JIRA) wrote:
>      [ https://issues.apache.org/jira/browse/DERBY-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996506#comment-12996506
]
>
> Dave Brosius commented on DERBY-5055:
> -------------------------------------
>
> some of them are findbugs, others are found just by code inspection, after looking at
'unrelated' findbugs results.
>
>> [patch] add visibility to static method calls
>> ---------------------------------------------
>>
>>                  Key: DERBY-5055
>>                  URL: https://issues.apache.org/jira/browse/DERBY-5055
>>              Project: Derby
>>           Issue Type: Improvement
>>           Components: Network Server
>>     Affects Versions: 10.7.1.1
>>             Reporter: Dave Brosius
>>             Priority: Trivial
>>              Fix For: 11.0.0.0
>>
>>          Attachments: static_visibility.diff
>>
>>    Original Estimate: 1h
>>   Remaining Estimate: 1h
>>
>> code in various spots calls static method calls thru instance variables. Patch brings
visibitity to these calls by calling thru static class. This exposes areas where code can
be removed (fetching the now unused instance variable).
Thank you Dave for all the great fixes and welcome to the Derby 
community! Thank you Knut for picking up all those patches!

We recently heard from Cesar Couto  asking if we used findbugs:

http://old.nabble.com/Do-Derby-developers-use-FindBugs--ts30762542.html#a30762542

I'll cc him on this thread in case he is not subscribed to the list. I 
am sure he would be interested in your findbugs findings for his research.

Kathey




Mime
View raw message