db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (DERBY-5020) [patch] remove redundant finalizer methods
Date Fri, 11 Feb 2011 11:43:57 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen resolved DERBY-5020.
---------------------------------------

          Resolution: Fixed
            Assignee: Dave Brosius
    Issue & fix info:   (was: [Patch Available])

We did see some performance issues on the embedded driver before that were caused by EmbedResultSet
overriding finalize(), so I think this would be good to get fixed. Thanks, Dave!

Committed revision 1069760.

> [patch] remove redundant finalizer methods
> ------------------------------------------
>
>                 Key: DERBY-5020
>                 URL: https://issues.apache.org/jira/browse/DERBY-5020
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 10.8.0.0
>
>         Attachments: remove_redundant_finalizers.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> code implements a finalize method by just calling super.finalize. Having a finalizer
makes the work of the gc harder than if you didn't have it at all, so remove it.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message