db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
Date Tue, 01 Feb 2011 16:52:29 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Rick Hillegas updated DERBY-4869:

    Attachment: derby-4869-21-ab-implicitlyClosedResultSets.diff

Thanks for the encouragement, Dag. Attaching derby-4869-21-ab-implicitlyClosedResultSets.diff.
This is a second rev of the patch for handling closeOnCompletion() when ResultSets close implicitly.
I am running regression tests now.

In this version of the patch, the Statement-closing logic is moved inside ResultSet.markClosed().
I found that I could make this work by factoring Statement.markClosed() into 2 pieces:

1) A piece which closes the ResultSets.

2) A piece which closes all of the other Statement resources.

Now the closeOnCompletion logic calls only the second piece of the Statement.markClosed()
logic. This ought to be safe since the ResultSets have already been closed.

I have added Dag's test case to the regression test for this behavior.

Touches the same files as the previous version of the patch.

> Implement JDBC 4.1, the api increment introduced by Java 7
> ----------------------------------------------------------
>                 Key: DERBY-4869
>                 URL: https://issues.apache.org/jira/browse/DERBY-4869
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: JDBC_4.1_Changes.html, derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff,
derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, derby-4869-03-aa-rs-getObject-errorCleanup.diff,
derby-4869-04-aa-rs-getObject-simplification.diff, derby-4869-05-aa-rs-getObject-exception.diff,
derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, derby-4869-07-aa-timedisplacement.diff,
derby-4869-08-ac-nullHandling.diff, derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff,
derby-4869-11-aa-abortHidePrivates.diff, derby-4869-12-aa-xaAndPooledAborts.diff, derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff,
derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, derby-4869-16-aa-clarifyStatementSpec.diff,
derby-4869-17-aa-statementTimeoutException.diff, derby-4869-18-aa-getSetSchema.diff, derby-4869-19-aa-getSetNetworkTimeout.diff,
derby-4869-20-aa-setSchemaFastPath.diff, derby-4869-21-aa-implicitlyClosedResultSets.diff,
derby-4869-21-ab-implicitlyClosedResultSets.diff, derby-4869-22-aa-unstableStatementTest.diff,
derby-4869-23-aa-dbmd.diff, derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff
> This is a master issue logged to track our work implementing JDBC 4.1, the changes to
the java.sql and javax.sql packages introduced by Java 7.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message