db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4982) Retrying after interrupts in store pops a bug in derbyall/storeall/storeunit/T_RawStoreFactory in some cases
Date Tue, 25 Jan 2011 09:40:44 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986295#action_12986295
] 

Knut Anders Hatlen commented on DERBY-4982:
-------------------------------------------

I think failing in both sane and insane is fine when we attempt to double-latch a page. That's
what this code did before DERBY-2107, only difference was that it would be a deadlock exception
from the lock manager after a 20 second delay. This should never happen unless we have a bug
somewhere, so what we chose to do is mainly a question about how keep the internal API testable.
And if we should have a bug that causes double-latching, a message telling that that's what
happened is probably more helpful than a hang.

The comment in BasePage.setExclusive() doesn't say that this is an attempt to double-latch
a page anymore. Perhaps expand on the comment to make it clearer why we error out?

The new message takes a parameter, but no value is provided in the call to newException().

> Retrying after interrupts in store pops a bug in derbyall/storeall/storeunit/T_RawStoreFactory
in some cases
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4982
>                 URL: https://issues.apache.org/jira/browse/DERBY-4982
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.8.0.0
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>         Attachments: derby-4982.diff, derby-4982.stat
>
>
> Cf Myrna's comment on DERBY-4741:
> "I think the latest check-in has caused the following tinderbox failure:
> derbyall/storeall/storeall.fail:unit/T_RawStoreFactory.unit
> see: http://dbtg.foundry.sun.com/derby/test/tinderbox_trunk16/jvm1.6/testing/testlog/SunOS-5.10_i86pc-i386/1061516-derbyall_diff.txt:
> ********* Diff file derbyall/storeall/storeunit/T_RawStoreFactory.diff
> *** Start: T_RawStoreFactory jdk1.6.0_18 storeall:storeunit 2011-01-20 23:22:23 ***
> 2 del
> < -- Unit Test T_RawStoreFactory finished
> 2 add
> > ran out of time
> > Exit due to time bomb
> Test Failed.
> *** End: T_RawStoreFactory jdk1.6.0_18 storeall:storeunit 2011-01-21 00:22:54 ***
> "
> It failed in the nightly runs with ibm 1.6 also (and 1.4.2 and 1.5). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message