Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 92991 invoked from network); 8 Dec 2010 11:48:26 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 8 Dec 2010 11:48:26 -0000 Received: (qmail 66272 invoked by uid 500); 8 Dec 2010 11:48:26 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 66081 invoked by uid 500); 8 Dec 2010 11:48:25 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 66066 invoked by uid 99); 8 Dec 2010 11:48:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Dec 2010 11:48:24 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Dec 2010 11:48:22 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oB8Bm0qm016021 for ; Wed, 8 Dec 2010 11:48:01 GMT Message-ID: <19536985.14371291808880732.JavaMail.jira@thor> Date: Wed, 8 Dec 2010 06:48:00 -0500 (EST) From: "Kristian Waagan (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Resolved: (DERBY-4928) Deadlock-prone synchronization in BasicDependencyManager In-Reply-To: <8961587.73021291297630638.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan resolved DERBY-4928. ------------------------------------ Resolution: Fixed Fix Version/s: 10.8.0.0 Issue & fix info: (was: [Patch Available]) Thanks for the review, Knut. I fixed the comment before committing patch 1a to trunk with revision 1043367. I don't plan to backport this fix, at least not now. We don't have any reports for this problem for earlier versions, so I'd rather see that the changes go through more testing before backporting. For the record, it was the automatic index statistics update feature that triggered the bug. > Deadlock-prone synchronization in BasicDependencyManager > -------------------------------------------------------- > > Key: DERBY-4928 > URL: https://issues.apache.org/jira/browse/DERBY-4928 > Project: Derby > Issue Type: Bug > Components: SQL > Affects Versions: 10.8.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Fix For: 10.8.0.0 > > Attachments: derby-4928-1a-depman_sync_and_cleanup.diff > > > The synchronization in BasicDependencyManager is prone to deadlock, because database locks are obtained while holding the monitor on "this". > Problem observed when testing the automatic index statistics update prototype. > There are comments in the file suggesting that in-memory dependencies should be accessed while holding the Java monitor, but the monitor should not be held when accessing stored dependencies. The implementation is breaking this rule/suggestion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.