Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <26940900.52471289596938500.JavaMail.jira@thor>
Date: Fri, 12 Nov 2010 16:22:18 -0500 (EST)
From: "Dag H. Wanvik (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Issue Comment Edited: (DERBY-4741) Make Derby work reliably
 in the presence of thread interrupts
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/DERBY-4741?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1293=
1526#action_12931526 ]=20

Dag H. Wanvik edited comment on DERBY-4741 at 11/12/10 4:22 PM:
----------------------------------------------------------------

Found that Derby uses interrupt to stop threads at shutdown[1]. The present=
 logic in RAFContainer4 doesn't
take this into account, with the consequence that an application thread got=
 stuck waiting for
a container recovery that never took place. We get an exception during exec=
ution of=20
                       closeContainer();
                        openContainer(currentIdentity);
If this exception is not due to an interrupt, we throw FILE_IO_INTERRUPTED.=
 Unfortunately, in this case,
the present patch neglects to release any threads waiting for recovery to f=
inish, so they are stuck waiting for "restoreChannelInProgress".

Saw this during suitesAll.

[1] BaseMonitor#shutdown -> notifyAllActiveThreads and in DatabaseContextIm=
pl#cleanupOnError->notifyAllActiveThreads


      was (Author: dagw):
    Found that Derby uses interrupt to stop threads at shutdown. The presen=
t logic in RAFContainer4 doesn't
take this into account, with the consequence that an application thread got=
 stuck waiting for
a container recovery that never took place. We get an exception during exec=
ution of=20
                       closeContainer();
                        openContainer(currentIdentity);
If this exception is not due to an interrupt, we throw FILE_IO_INTERRUPTED.=
 Unfortunately, in this case,
the present patch neglects to release any threads waiting for recovery to f=
inish, so they are stuck waiting for "restoreChannelInProgress".

Saw this during suitesAll.

 =20
> Make Derby work reliably in the presence of thread interrupts
> -------------------------------------------------------------
>
>                 Key: DERBY-4741
>                 URL: https://issues.apache.org/jira/browse/DERBY-4741
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.2.1.6, 10.2.2.0, 10.3.1.4, 10.3.2.1, 10.3.3.0, 10=
.4.1.3, 10.4.2.0, 10.5.1.1, 10.5.2.0, 10.5.3.0, 10.6.1.0
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>         Attachments: derby-4741-a-01-api-interruptstatus.diff, derby-4741=
-a-01-api-interruptstatus.stat, derby-4741-a-02-api-interruptstatus.diff, d=
erby-4741-a-02-api-interruptstatus.stat, derby-4741-a-03-api-interruptstatu=
s.diff, derby-4741-a-03-api-interruptstatus.stat, derby-4741-a-04-api-inter=
ruptstatus.diff, derby-4741-a-04-api-interruptstatus.stat, derby-4741-all+l=
enient+resurrect.diff, derby-4741-all+lenient+resurrect.stat, derby-4741-b-=
01-nio.diff, derby-4741-b-01-nio.stat, derby-4741-b-02-nio.diff, derby-4741=
-b-02-nio.stat, derby-4741-nio-container+log+waits+locks+throws.diff, derby=
-4741-nio-container+log+waits+locks+throws.stat, derby-4741-nio-container+l=
og+waits+locks-2.diff, derby-4741-nio-container+log+waits+locks-2.stat, der=
by-4741-nio-container+log+waits+locks.diff, derby-4741-nio-container+log+wa=
its+locks.stat, derby-4741-nio-container+log+waits.diff, derby-4741-nio-con=
tainer+log+waits.stat, derby-4741-nio-container+log.diff, derby-4741-nio-co=
ntainer+log.stat, derby-4741-nio-container-2.diff, derby-4741-nio-container=
-2.log, derby-4741-nio-container-2.stat, derby-4741-nio-container-2b.diff, =
derby-4741-nio-container-2b.stat, derby.log, derby.log, InterruptResilience=
Test.java, MicroAPITest.java, xsbt0.log.gz
>
>
> When not executing on a small device VM, Derby has been using the Java NI=
O classes java.nio.clannel.* for file io.
> If thread is interrupted while executing blocking IO operations in NIO, t=
he ClosedByInterruptException will get thrown. Unfortunately, Derby isn't c=
urrent architected to retry and complete such operations (before passing on=
 the interrupt), so the Derby database can be left in an inconsistent state=
 and we therefore have to return a database level error. This means the app=
lications can no longer access the database without a shutdown and reboot i=
ncluding a recovery.
> It would be nice if Derby could somehow detect and finish IO operations u=
nderway when thread interrupts happen before passing the exception on to th=
e application. Derby embedded is sometimes embedded in applications that us=
e Thread.interrupt to stop threads.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.