Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <13004584.27331289487975449.JavaMail.jira@thor>
Date: Thu, 11 Nov 2010 10:06:15 -0500 (EST)
From: "Bryan Pendleton (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-4899) Refactor access to primary
 structures in AlterTableConstantAction
In-Reply-To: <15621958.25161289476901453.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-4899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931033#action_12931033 ] 

Bryan Pendleton commented on DERBY-4899:
----------------------------------------

+1 to simplifying and removing unnecessary code!


> Refactor access to primary structures in AlterTableConstantAction
> -----------------------------------------------------------------
>
>                 Key: DERBY-4899
>                 URL: https://issues.apache.org/jira/browse/DERBY-4899
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.7.1.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-4899-1a-cleanup.diff
>
>
> Many of the private methods in impl.sql.execute.AlterTableConstantAction take the activation (and sometimes a number of references obtained through it) as an argument. This seems unnecessary, and it clutters the code with argument passing, boilerplate code and variable hiding.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.