db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4899) Refactor access to primary structures in AlterTableConstantAction
Date Thu, 11 Nov 2010 23:42:13 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931269#action_12931269

Dag H. Wanvik commented on DERBY-4899:

Looks good to me, geez that was really messy. 

> Refactor access to primary structures in AlterTableConstantAction
> -----------------------------------------------------------------
>                 Key: DERBY-4899
>                 URL: https://issues.apache.org/jira/browse/DERBY-4899
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions:
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-4899-1a-cleanup.diff
> Many of the private methods in impl.sql.execute.AlterTableConstantAction take the activation
(and sometimes a number of references obtained through it) as an argument. This seems unnecessary,
and it clutters the code with argument passing, boilerplate code and variable hiding.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message