db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4822) DropSchemaConstantAction: could reuse the current connection provided by the available activation object
Date Fri, 05 Nov 2010 13:44:43 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rick Hillegas updated DERBY-4822:
---------------------------------

    Summary: DropSchemaConstantAction: could reuse the current connection provided by the
available activation object  (was: [patch] DropSchemaConstantAction: could reuse the current
connection provided by the available activation object)

Removing the [patch] tag from the issue description. When those square brackets turn up in
the release notes they will confuse the Forrest tool which creates a download page from our
release notes.

> DropSchemaConstantAction: could reuse the current connection provided by the available
activation object
> --------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4822
>                 URL: https://issues.apache.org/jira/browse/DERBY-4822
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.7.1.0
>            Reporter: Martin Monperrus
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.7.1.0
>
>         Attachments: patch.txt
>
>
> In DropSchemaConstantAction.executeConstantAction, getSchemaDescriptor is called with
a null parameter. Instead, one could reuse the current transaction controller directly available
with "activation.getLanguageConnectionContext().getTransactionExecute()" as it's done with
other subclasses of DDLConstantAction. 
> Regards, --Martin
> Index: java/engine/org/apache/derby/impl/sql/execute/DropSchemaConstantAction.java
> ===================================================================
> --- java/engine/org/apache/derby/impl/sql/execute/DropSchemaConstantAction.java (revision
1001658)
> +++ java/engine/org/apache/derby/impl/sql/execute/DropSchemaConstantAction.java (working
copy)
> @@ -27,6 +27,7 @@
>  import org.apache.derby.iapi.sql.dictionary.DataDictionary;
>  import org.apache.derby.iapi.sql.dictionary.SchemaDescriptor;
>  import org.apache.derby.iapi.sql.execute.ConstantAction;
> +import org.apache.derby.iapi.store.access.TransactionController;
>  
>  /**
>   *     This class  describes actions that are ALWAYS performed for a
> @@ -82,6 +83,7 @@
>         {
>                 LanguageConnectionContext lcc = activation.getLanguageConnectionContext();
>                 DataDictionary dd = lcc.getDataDictionary();
> +               TransactionController tc = lcc.getTransactionExecute();
>  
>                 /*
>                 ** Inform the data dictionary that we are about to write to it.
> @@ -94,7 +96,7 @@
>                 */
>                 dd.startWriting(lcc);
>  
> -        SchemaDescriptor sd = dd.getSchemaDescriptor(schemaName, null, true);
> +        SchemaDescriptor sd = dd.getSchemaDescriptor(schemaName, tc, true);
>  
>          sd.drop(lcc, activation);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message