Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 6249 invoked from network); 24 Sep 2010 00:36:14 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 24 Sep 2010 00:36:14 -0000 Received: (qmail 85611 invoked by uid 500); 24 Sep 2010 00:36:14 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 85579 invoked by uid 500); 24 Sep 2010 00:36:13 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 85572 invoked by uid 99); 24 Sep 2010 00:36:13 -0000 Received: from Unknown (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Sep 2010 00:36:13 +0000 X-ASF-Spam-Status: No, hits=-1996.4 required=10.0 tests=ALL_TRUSTED,FS_REPLICA X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Sep 2010 00:35:56 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o8O0ZYl8013177 for ; Fri, 24 Sep 2010 00:35:35 GMT Message-ID: <15772259.375641285288534627.JavaMail.jira@thor> Date: Thu, 23 Sep 2010 20:35:34 -0400 (EDT) From: "Kathey Marsden (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Created: (DERBY-4819) add error reporting to ReplicationMessageTransmit.java MasterReceiverThread.run() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org add error reporting to ReplicationMessageTransmit.java MasterReceiverThread.run() --------------------------------------------------------------------------------- Key: DERBY-4819 URL: https://issues.apache.org/jira/browse/DERBY-4819 Project: Derby Issue Type: Bug Components: Replication Affects Versions: 10.6.1.0, 10.5.3.0, 10.4.2.0, 10.7.0.0 Reporter: Kathey Marsden While working on DERBY-4812, I noticed the following code in MasterReceiverThread,run(). I am not familiar enough with replication to know if the MasterReceiverThread can recover from such errors. If it cannot i think it would better to have a clear failure at the time of the error than just a subsequent NullPointerException. As the todo says, the exceptions should at least be logged. Also I just noticed this one bit of code, so don't know if there are similar issues or TODO's elsewhere in replication code. } catch (SocketTimeoutException ste) { // ignore socket timeout on reads } catch (ClassNotFoundException cnfe) { // TODO: print problem to log } catch (IOException ex) { // TODO: print problem to log // If we get an exception for this socket, the log shipper // will clean up. Stop this thread. stopMessageReceiver = true; msgReceiver = null; } } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.