db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4757) (Client) Implement UTF8 support on DRDA
Date Thu, 02 Sep 2010 14:19:54 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905515#action_12905515

Bryan Pendleton commented on DERBY-4757:

> making sure that we don't even try to send an RDBNAM at ACCSEC if we can't convert it.

Thanks for the clear and precise explanation. Your technique seems appropriate to me.

Regarding whether extra comments are needed in the code: I have found it sufficient in
the past, when studying a change to the code, to be able to trace the change back to a
Jira entry and then read the comments in the Jira in detail. So, in this case, i would say
that your explanation in the Jira entry is very helpful and clear, and I don't think that
additional change to the patch is necessary.

> (Client) Implement UTF8 support on DRDA
> ---------------------------------------
>                 Key: DERBY-4757
>                 URL: https://issues.apache.org/jira/browse/DERBY-4757
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Client
>    Affects Versions:
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4757_donotcommit.diff, DERBY-4757_p1.diff, DERBY-4757_p2.diff,
> This issue is DERBY-4746's counterpart for the client changes required to implement UTF8
support in DRDA.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message