db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3986) Stop dropping build artifacts in the subversion-controlled source tree
Date Thu, 30 Sep 2010 12:52:38 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-3986:

    Attachment: filemode.diff

One small observation regarding the "filemode" attribute error mentioned above. The change
that triggered it introduced a tiny inconsistency, as can be seen here:

      <!-- bin -->
      <tarfileset dir="${basedir}/bin" prefix="${derby.bin}/bin" 
                  mode="755" includes="*" excludes="templates"/>
      <tarfileset dir="${generated.bin.dir}" prefix="${derby.bin}/bin" 
                  filemode="755" includes="*"/>

The old target uses the "mode" attribute, whereas the new target uses "filemode". We should
use the same for both the tarfilesets. "mode" seems to work with both Ant 1.6.5 and Ant 1.7.x,
but only "filemode" is mentioned in the 1.7.x manuals, as far as I can see, so we should probably
stick to that one.

Unless there are any objections, I plan to commit the attached patch (filemode.diff) to make
both the tarfilesets use "filemode".

> Stop dropping build artifacts in the subversion-controlled source tree
> ----------------------------------------------------------------------
>                 Key: DERBY-3986
>                 URL: https://issues.apache.org/jira/browse/DERBY-3986
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>    Affects Versions:
>            Reporter: Rick Hillegas
>         Attachments: chmod.diff, derby-3986-01-aa-checkCompilerLevel.diff, derby-3986-02-af-sanity-bin-toursdb-storeless-release.diff,
derby-3986-02-ag-sanity-bin-toursdb-storeless-release.diff, derby-3986-02-ah-sanity-bin-toursdb-storeless-release.diff,
filemode.diff, mk-sanity-dir.diff
> The Derby build drops various artifacts in the source tree. Build artifacts should not
muddy subversion controlled directories but should, instead, go into temporary directories
created by the the build. 
> The following is a (perhaps partial) list of artifacts currently dropped into subversion-controlled
> Sanity directives
> Generated grammars
> The English error messages
> Data type class sizes
> Toursdb
> Temporary class for verifying compiler level

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message