db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4757) (Client) Implement UTF8 support on DRDA
Date Thu, 02 Sep 2010 02:06:53 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905375#action_12905375
] 

Bryan Pendleton commented on DERBY-4757:
----------------------------------------

The change looks clean to me, thanks very much for the detailed description!

The only part of the patch that I didn't understand was this:


@@ -355,7 +359,7 @@
         // support.  the size will have ben previously checked so at this point just
         // write the data and pad with the correct number of bytes as needed.
         // this instance variable is always required.
-        buildRDBNAM(rdbnam,false);
+        buildRDBNAM(rdbnam,true);
 
         // the rdb access manager class specifies an instance of the SQLAM
         // that accesses the RDB.  the sqlam manager class codepoint

Can you clarify the purpose of this change?

Thanks!


> (Client) Implement UTF8 support on DRDA
> ---------------------------------------
>
>                 Key: DERBY-4757
>                 URL: https://issues.apache.org/jira/browse/DERBY-4757
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Client
>    Affects Versions: 10.7.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4757_donotcommit.diff, DERBY-4757_p1.diff, DERBY-4757_p2.diff,
DERBY-4757_p3.diff
>
>
> This issue is DERBY-4746's counterpart for the client changes required to implement UTF8
support in DRDA.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message