db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4757) (Client) Implement UTF8 support on DRDA
Date Fri, 10 Sep 2010 02:01:33 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907863#action_12907863

Bryan Pendleton commented on DERBY-4757:

I read through your changes and they look good to me.

+1 to commit the _v3 patch, once you're comfortable with your test results.

If you'd prefer to submit the DRDAConnThread.java change separately,
and indicate in the subversion log description that it is part of DERBY-4746,
that seems fine to me.

I think it's also fine to submit that change as part of this work. As you note,
the various changes are intertwined, and I don't foresee anyone wishing
to use only the server changes, or only the client changes, so I think it's
fine to include that change here.

Thanks for all the effort and hard work getting these changes in shape for
the upcoming release!

> (Client) Implement UTF8 support on DRDA
> ---------------------------------------
>                 Key: DERBY-4757
>                 URL: https://issues.apache.org/jira/browse/DERBY-4757
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Client
>    Affects Versions:
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4757_donotcommit.diff, DERBY-4757_p1.diff, DERBY-4757_p2.diff,
DERBY-4757_p3.diff, DERBY-4757_p3.diff
> This issue is DERBY-4746's counterpart for the client changes required to implement UTF8
support in DRDA.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message