db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (DERBY-4765) Convert "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to junit.
Date Fri, 13 Aug 2010 23:19:15 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Myrna van Lunteren resolved DERBY-4765.

    Issue & fix info:   (was: [Patch Available])
       Fix Version/s:
          Resolution: Fixed

Thanks Yun for the updated patch. 
I made 3 tiny changes:
- changed the text for the asserts because it suggested the pings would add text to the log;
they don't (in the original test, the connections did, but now it's only the start and shutdown
- moved the assert for empty log up to before the server.start
   This seems a bit superfluous, but I wanted to prevent the -unlikely- situation that the
text would already be there by the time the assert was done; which could possibly result in
false failures.
- rearranged the tests in _Suite.java so there's only one if (JDBC.vmSupportsJDBC3()) block.

committed with revision 985400.

> Convert "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to junit.
> ------------------------------------------------------------------------------------------
>                 Key: DERBY-4765
>                 URL: https://issues.apache.org/jira/browse/DERBY-4765
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>            Reporter: Yun Lee
>            Assignee: Yun Lee
>             Fix For:
>         Attachments: derby-4765-1.patch, derby-4765-1.stat, derby-4765.patch, derby-4765.stat

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message