db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tiago R. Espinha (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4746) (Server) Implement UTF8 support on DRDA
Date Thu, 29 Jul 2010 09:46:16 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893567#action_12893567
] 

Tiago R. Espinha commented on DERBY-4746:
-----------------------------------------

Oh I see why this happens, it has to do with DERBY-2031.

I think this is a mess in maintainability though... the original goal of DERBY-2031 was to
convert the whole functionality of derbynet/testProtocol.java to a proper JUnit test and this
is how impl/drda/ProtocolTest.java came to life. However, as it is, each time we add a feature
to the JUnit protocol test we have to do the same for the other or it'll break.

I'm not sure what to do about this. Do we want to maintain these two tests that do essentially
the same? I can easily implement the switchToUtf8CcsidManager logic in the testProtocol as
well but should I do it?

> (Server) Implement UTF8 support on DRDA
> ---------------------------------------
>
>                 Key: DERBY-4746
>                 URL: https://issues.apache.org/jira/browse/DERBY-4746
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.7.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4746.diff, DERBY-4746.diff, DERBY-4746.diff, DERBY-4746_p2-impl.diff,
DERBY-4746_p2-impl.diff, DERBY-4746_p2-tests.diff
>
>
> I'm branching out this issue into server and client changes. Since the changes are incremental
and small, DERBY-728 would soon become confusing if it had to bear the patches for both server
and client.
> For future reference, some patches have actually been applied in DERBY-728. These **ARE**
also required for the server implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message