db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4746) (Server) Implement UTF8 support on DRDA
Date Thu, 29 Jul 2010 16:40:17 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893691#action_12893691

Bryan Pendleton commented on DERBY-4746:

Thanks for drawing my attention to DERBY-2031; I had forgotten about that entirely.

Kristian's final comment in that issue was:
> Changes done to the protocol test file will affect both versions of the test. 

So I guess that means that, for now, the two-versions-of-the-same-test is our
reality, so if it's not too hard to add the duplicate logic to the other test, I'd say
that would be fine.

It's far better to have too many tests than too few, and this does seem like a really
special situation.

Would the additional change be a large one?

Also, are you anticipating writing additional tests in this area as part of your
upcoming work? Or is this a one-time-only situation? If this will become an
annoying thorn in your side than maybe we need to look for an alternate idea?

I suppose that the alternate idea might be:
1) Pick *one* version of the DERBY-2031 tests to preserve for the future (presumably,
the JUnit version)
2) Entirely discard the old version of the tests
3) Document in the code and in the wiki, etc. how to run the new test, and explain
to the community that this test is special and needs to be run, periodically, in
this special fashion.

BTW, when I did "ant junit-pptesting", was I running the new DERBY-2031 JUnit test? And was
I doing that against the 'classes' directory in my build tree?

> (Server) Implement UTF8 support on DRDA
> ---------------------------------------
>                 Key: DERBY-4746
>                 URL: https://issues.apache.org/jira/browse/DERBY-4746
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions:
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4746.diff, DERBY-4746.diff, DERBY-4746.diff, DERBY-4746_p2-impl.diff,
DERBY-4746_p2-impl.diff, DERBY-4746_p2-tests.diff
> I'm branching out this issue into server and client changes. Since the changes are incremental
and small, DERBY-728 would soon become confusing if it had to bear the patches for both server
and client.
> For future reference, some patches have actually been applied in DERBY-728. These **ARE**
also required for the server implementation.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message