db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4601) Shutting down just a single database should log a different message than shutting down the system
Date Tue, 20 Jul 2010 09:41:50 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890223#action_12890223
] 

Knut Anders Hatlen commented on DERBY-4601:
-------------------------------------------

Mamta posted a patch for this issue on DERBY-4610. I'm adding my comments here:

1) loc/messages.xml:

+                <text>:Shutting down Derby Engine </text>

Is the colon before "Shutting" and the blank space after "Engine" intended? If so, would it
be better to add those characters using literals in BaseMonitor.java (same way as we use a
literal there to add an extra newline)? I think there's a good chance that translators will
think the characters are not part of the message and will leave them out.

2) BaseDataFileFactory.java:

                 MessageService.getTextMessage(
                     MessageId.STORE_SHUTDOWN_MSG,
-                    getIdentifier(), 
+                    getIdentifier()+" on database directory "+getRootDirectory(),

Hard-coding English text as an argument to an internationalized message like this will make
the message look awkward when it's localized to another language. It would be better to change
STORE_SHUTDOWN_MSG to take an extra argument (the root directory).

> Shutting down just a single database should log a different message than shutting down
the system
> -------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4601
>                 URL: https://issues.apache.org/jira/browse/DERBY-4601
>             Project: Derby
>          Issue Type: Bug
>          Components: Services
>    Affects Versions: 10.5.3.0
>            Reporter: Kathey Marsden
>            Assignee: A.S.Thiwanka Somasiri
>            Priority: Minor
>         Attachments: derby-4601.diff
>
>
> When shutting down just a single database and not the Derby system, the log should print
a message that just that database was shutdown as I believe Derby is still loaded.
> e.g.
> ij version 10.6
> ij> run 'testMessages.sql';
> ij> connect 'jdbc:derby:wombat';
> ij> connect 'jdbc:derby:wombat2';
> ij(CONNECTION1)> connect 'jdbc:derby:wombat2;shutdown=true';
> ERROR 08006: Database 'wombat2' shutdown.
> ij(CONNECTION1)> connect 'jdbc:derby:;shutdown=true';
> ERROR XJ015: Derby system shutdown.
> yields the following log:
> 2010-03-26 15:27:16.375 GMT:
>  Booting Derby version The Apache Software Foundation - Apache Derby - 10.6.0.0 alpha
- (927879M): instance a816c00e-0127-9b15-988d-0000002083e0 
> on database directory C:\kmarsden\repro\DERBY-4588\wombat   with class loader sun.misc.Launcher$AppClassLoader@42c042c0
> Database Class Loader started - derby.database.classpath=''
> ----------------------------------------------------------------
> 2010-03-26 15:27:16.921 GMT:
>  Booting Derby version The Apache Software Foundation - Apache Derby - 10.6.0.0 alpha
- (927879M): instance 601a400f-0127-9b15-988d-0000002083e0 
> on database directory C:\kmarsden\repro\DERBY-4588\wombat2   with class loader sun.misc.Launcher$AppClassLoader@42c042c0
> Database Class Loader started - derby.database.classpath=''
> 2010-03-26 15:27:17.171 GMT:
> Shutting down instance 601a400f-0127-9b15-988d-0000002083e0 with class loader sun.misc.Launcher$AppClassLoader@42c042c0

> ----------------------------------------------------------------
> 2010-03-26 15:27:17.218 GMT:
> Shutting down instance a816c00e-0127-9b15-988d-0000002083e0 with class loader sun.misc.Launcher$AppClassLoader@42c042c0

> ----------------------------------------------------------------
> The first shutdown should say that just the database wombat2 was shutdown, not the entire
system.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message