db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4746) (Server) Implement UTF8 support on DRDA
Date Fri, 23 Jul 2010 22:55:50 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891841#action_12891841
] 

Kathey Marsden commented on DERBY-4746:
---------------------------------------

Hi Tiago,

I looked at the patches (although in a bit of a hurry)  and they look good except that I am
not sure about adding the DriverManager Import to ProtocolTest because of possible J2ME issues.
It may be fine as the network server tests don't actually run for J2ME but I am not sure.
  It might be better instead to use JDBCDataSource.getDataSource() and then JDBCDataSource.shutdownDatabase().

Also I don't think  public static final int EBCDIC_CCSID = 500; is used and might be a bit
confusing since I UNICODEMGR uses 0 for EBCDIC as I recall. Sorry for the hurried comments.
 I hope another commiter picks up the patches.

bye for now!

Kathey



> (Server) Implement UTF8 support on DRDA
> ---------------------------------------
>
>                 Key: DERBY-4746
>                 URL: https://issues.apache.org/jira/browse/DERBY-4746
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.7.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4746.diff, DERBY-4746.diff, DERBY-4746.diff, DERBY-4746_p2-impl.diff,
DERBY-4746_p2-tests.diff
>
>
> I'm branching out this issue into server and client changes. Since the changes are incremental
and small, DERBY-728 would soon become confusing if it had to bear the patches for both server
and client.
> For future reference, some patches have actually been applied in DERBY-728. These **ARE**
also required for the server implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message