db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
Date Tue, 20 Jul 2010 10:27:50 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890230#action_12890230

Knut Anders Hatlen commented on DERBY-4715:

Sorry, I missed one issue when I looked through the patch:

In BaseDataFileFactory.java, there's this diff:

-                                             dataDirectory + " " + readOnlyMsg,
                                              // cast to Object so we get object hash code
-                                             (Object) this.getClass().getClassLoader()
+                                             (Object) this.getClass().getClassLoader(),
+                                             dataDirectory + " " + readOnlyMsg 
+                                             +"\nLoaded from " + jarCPath + "\n" +jvmVersion

Since we hard-code English text as an argument to STORE_BOOT_MSG, only parts of the message
will be translated in non-English locales. We should instead add extra arguments to the STORE_BOOT_MSG
message and make the hard-coded English strings part of the message text in messages.xml.

Also, the patch changed the order of the arguments in that call, so now the message looks
like this:

Booting Derby version The Apache Software Foundation - Apache Derby - alpha - (1):
instance a816c00e-0129-ef61-4e78-00000348df10 
on database directory sun.misc.Launcher$AppClassLoader@13f5d07  with class loader /tmp/testdb

Note that it says that "sun.misc.Launcher$AppClassLoader@13f5d07" is a database directory
and "/tmp/testdb" is a class loader, but it should have been the other way around.

> Write jvm information and path of derby.jar to derby.log
> --------------------------------------------------------
>                 Key: DERBY-4715
>                 URL: https://issues.apache.org/jira/browse/DERBY-4715
>             Project: Derby
>          Issue Type: Bug
>          Components: Miscellaneous
>    Affects Versions:
>            Reporter: Lily Wei
>            Assignee: Lily Wei
>            Priority: Minor
>             Fix For:
>         Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, DERBY-4715-4.diff,
DERBY-4715-5.diff, derby.log
> The bug is part of DERBY-1272. In production environment, derby.jar can be located different
than the derbyclient.jar It can be easier if we have jvm version information and path of derby.jar
are in the derby.log

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message