db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (DERBY-4746) (Server) Implement UTF8 support on DRDA
Date Tue, 20 Jul 2010 00:31:49 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890101#action_12890101
] 

Kathey Marsden edited comment on DERBY-4746 at 7/19/10 8:30 PM:
----------------------------------------------------------------

Hi Tiago,

In Utf8CcsidManager.convertToJavaString I think it would be more efficient to just use.
String(byte[] bytes, int offset, int length, String charsetName)
          Constructs a new String by decoding the specified subarray of bytes using the specified
charset.

Instead of creating a new byte array and copying into it.

The rest looks good.

      was (Author: kmarsden):
    Hi Tiago,

In Utf8CcsidManager.convertToJavaString I think it would be more efficient to just use.
String(byte[] bytes, int offset, int length, Charset charset)
          Constructs a new String by decoding the specified subarray of bytes using the specified
charset.

Instead of creating a new byte array and copying into it.

The rest looks good.
  
> (Server) Implement UTF8 support on DRDA
> ---------------------------------------
>
>                 Key: DERBY-4746
>                 URL: https://issues.apache.org/jira/browse/DERBY-4746
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.7.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4746.diff, DERBY-4746.diff
>
>
> I'm branching out this issue into server and client changes. Since the changes are incremental
and small, DERBY-728 would soon become confusing if it had to bear the patches for both server
and client.
> For future reference, some patches have actually been applied in DERBY-728. These **ARE**
also required for the server implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message