db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tiago R. Espinha (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4746) (Server) Implement UTF8 support on DRDA
Date Thu, 29 Jul 2010 17:16:21 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893711#action_12893711
] 

Tiago R. Espinha commented on DERBY-4746:
-----------------------------------------

The additional change is small. I just need to add the new command to the testProtocol grammar
and tell the Java code what to do with it, which is a rather small change.

My only concern has to do with maintainability. We have two sets of everything for this test:
two grammars, two separate logics for each of the same commands in the protocols.test file,
etc - this shouldn't pose as a problem unless we're adding new grammar to the tests though,
I just have a certain aversion to code repetition #:)

For my tests, this shouldn't be a problem again I think.

I do agree with your solution for DERBY-2031. As it is the tests aren't being ran as part
of suites.All anyway, so whoever touches the DRDA code should be aware of these protocol tests.
So as long as we document how to run them, I think this solution should be fine. I'll suggest
this on DERBY-2031.

With ant junit-pptesting you were indeed running the new JUnit test (ProtocolTest.java) and
it is ran against the classes in your build tree.

I will submit a new patch in a few minutes that adds the changes to the testProtocol.

> (Server) Implement UTF8 support on DRDA
> ---------------------------------------
>
>                 Key: DERBY-4746
>                 URL: https://issues.apache.org/jira/browse/DERBY-4746
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.7.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4746.diff, DERBY-4746.diff, DERBY-4746.diff, DERBY-4746_p2-impl.diff,
DERBY-4746_p2-impl.diff, DERBY-4746_p2-tests.diff
>
>
> I'm branching out this issue into server and client changes. Since the changes are incremental
and small, DERBY-728 would soon become confusing if it had to bear the patches for both server
and client.
> For future reference, some patches have actually been applied in DERBY-728. These **ARE**
also required for the server implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message