Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 60895 invoked from network); 21 Jun 2010 13:21:47 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 21 Jun 2010 13:21:47 -0000 Received: (qmail 31587 invoked by uid 500); 21 Jun 2010 13:21:47 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 31363 invoked by uid 500); 21 Jun 2010 13:21:44 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 31345 invoked by uid 99); 21 Jun 2010 13:21:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Jun 2010 13:21:43 +0000 X-ASF-Spam-Status: No, hits=-1534.2 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Jun 2010 13:21:43 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o5LDLMkl026422 for ; Mon, 21 Jun 2010 13:21:23 GMT Message-ID: <21585229.109551277126482827.JavaMail.jira@thor> Date: Mon, 21 Jun 2010 09:21:22 -0400 (EDT) From: "Kristian Waagan (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Resolved: (DERBY-4706) Remove stale and potentially unused code Request.writeEncryptedScalarStream In-Reply-To: <5808069.107741277114782992.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan resolved DERBY-4706. ------------------------------------ Fix Version/s: 10.7.0.0 Resolution: Fixed I do plan to back-port this issue after verification, because the client-side only fix for DERBY-1595 depends on it (just for a clean merge, not functionally). > Remove stale and potentially unused code Request.writeEncryptedScalarStream > --------------------------------------------------------------------------- > > Key: DERBY-4706 > URL: https://issues.apache.org/jira/browse/DERBY-4706 > Project: Derby > Issue Type: Task > Components: Network Client > Affects Versions: 10.7.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Trivial > Fix For: 10.7.0.0 > > Attachments: derby-4706-1a-remove_writeEncryptedScalarStream_and_friends.diff > > > The code in net.Request.writeEncryptedScalarStream() is in a bad state, for instance: > - it materializes the stream > - it doesn't support streams longer than Integer.MAX_VALUE > (this is fine for BLOB since Derby limits the LOB size to 2G-1, but for CLOBs the data stream may be longer since the length is expressed in characters) > - in some error situations it causes a disconnect > Since the security mechanisms required to run this code (SECMEC_EUSRIDDTA and SECMEC_EUSRPWDDTA) are apparently supported in the client but not in the network server, deleting it seems like a good option considering its state. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.