Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 10601 invoked from network); 16 Jun 2010 08:56:51 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 16 Jun 2010 08:56:51 -0000 Received: (qmail 85759 invoked by uid 500); 16 Jun 2010 08:56:51 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 85530 invoked by uid 500); 16 Jun 2010 08:56:48 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 85523 invoked by uid 99); 16 Jun 2010 08:56:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Jun 2010 08:56:47 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Jun 2010 08:56:45 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o5G8uN7m021819 for ; Wed, 16 Jun 2010 08:56:23 GMT Message-ID: <16526468.26161276678583325.JavaMail.jira@thor> Date: Wed, 16 Jun 2010 04:56:23 -0400 (EDT) From: "Kristian Waagan (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-4700) Add method to obtain a bogus port in TestConfiguration In-Reply-To: <4169291.1681276583304138.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879281#action_12879281 ] Kristian Waagan commented on DERBY-4700: ---------------------------------------- Makes sense to follow an existing pattern. Note that there are eight constructors... BTW, the extra logic for the other approach would be changing '>' to '>=' ;) In a way we are wasting ports by allocating them even if they are not used, but I think it is better to allocate them early on for the sake of clarity. Should we also add debug print outs for the additional ports (jmx and bogus) to aid debugging port conflicts? > Add method to obtain a bogus port in TestConfiguration > ------------------------------------------------------ > > Key: DERBY-4700 > URL: https://issues.apache.org/jira/browse/DERBY-4700 > Project: Derby > Issue Type: Improvement > Components: Test > Affects Versions: 10.7.0.0 > Reporter: Kristian Waagan > Priority: Minor > > In some cases one needs to obtain a port number on which there is no Derby network server. > Today this is solved in an ad-hoc way, for instance by using the current port minus one. When running tests in parallel, there is a chance that a port where there actually is a Derby network server listening is picked. > As a start, I suggest that the bogus port is allocated to the last port in the port range configured for the run: baseport + MAX_PORTS_USED -1. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.