db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (DERBY-2419) Tighten encapsulation of state in TestConfiguration
Date Thu, 17 Jun 2010 10:27:26 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879736#action_12879736
] 

Kristian Waagan edited comment on DERBY-2419 at 6/17/10 6:27 AM:
-----------------------------------------------------------------

I'm marking this as fixed.
The issue has been hanging around for a long time. Tiago improved the situation a lot with
DERBY-4217, and Rick's concern about the use of the default port has been addressed (maybe
by the same Jira?).
The issue Rick pointed out is still valid for DEFAULT_HOSTNAME, but that is less critical
than using DEFAULT_PORT. It can be dealt with under a separate Jira issue.

Feel free to reopen if you think marking this issue as fixed is wrong.

      was (Author: kristwaa):
    I'm marking this as fixed.
The issue has been hanging around for a long time. Tiago improved the situation a lot with
DERBY-4090, and Rick's concern about the use of the default port has been addressed (maybe
by the same Jira?).
The issue Rick pointed out is still valid for DEFAULT_HOSTNAME, but that is less critical
than using DEFAULT_PORT. It can be dealt with under a separate Jira issue.

Feel free to reopen if you think marking this issue as fixed is wrong.
  
> Tighten encapsulation of state in TestConfiguration
> ---------------------------------------------------
>
>                 Key: DERBY-2419
>                 URL: https://issues.apache.org/jira/browse/DERBY-2419
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.3.1.4
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.7.0.0
>
>         Attachments: derby-2419-1a-alternative1.diff, derby-2419-2a-alternative2.diff,
derby-2419-2a-alternative2.stat, derby-2419-3a-further_encapsulation.diff, derby-2419-refactor-01.diff
>
>
> Parts of the state of TestConfiguration has been made public, which they should not be;
DEFAULT_PORT and DEFAULT_HOSTNAME.
> Using these directly from the outside can cause settings overridden by the user to be
ignored by tests. Further, a test should not care if the host/port it uses is the Derby default
or the values set by the user running the test.
> To obtain a hostname and  a port number, use the methods getPort and getHostName in TestConfiguration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message