db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4725) Fix message build so that double quotes aren't inserted for English messages.
Date Tue, 29 Jun 2010 20:18:50 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883680#action_12883680
] 

Knut Anders Hatlen commented on DERBY-4725:
-------------------------------------------

I tested the following code:

        String pattern = "Don't use single quotes! They're no good!";
        String msg = MessageFormat.format(pattern, new Object[0]);
        System.out.println(msg);

And here's what was printed:

Dont use single quotes! Theyre no good!

Also, some of our messages already use a single quote instead of double quotes. One example
is this message in the Italian translation:

42X34=Esiste un parametro ? nell'elenco di selezione.  Ci\u00F2 non \u00E8 consentito.

Here's what it looks like when the error is raised:

ij> select ? from sysibm.sysdummy1;
ERRORE 42X34: Esiste un parametro ? nellelenco di selezione.  Ciò non è consentito.

Note that it says "nellelenco" instead of "nell'elenco". So it seems to me that we should
rather try to use double quotes consistently instead of moving to single quotes.

> Fix message build so that double quotes aren't inserted for English messages.
> -----------------------------------------------------------------------------
>
>                 Key: DERBY-4725
>                 URL: https://issues.apache.org/jira/browse/DERBY-4725
>             Project: Derby
>          Issue Type: Improvement
>          Components: Localization
>    Affects Versions: 10.6.1.0
>            Reporter: Rick Hillegas
>            Priority: Minor
>
> When messages_en.properties is generated from messages.xml, single quotes are turned
into double quotes. For instance, the text for 42XAC is turned into 
> ''INCREMENT BY'' value can not be zero.
> This doesn't seem to cause any harm. MessageFormat does the right thing and strips out
the extra quote. If the messages only have single quotes, MessageFormat also does the right
thing and leaves the phrase single-quoted. The double quotes, however, are confusing to the
people who are localizing the 10.6 messages. There would be less confusion if the build did
not insert extra quotes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message