db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4716) Enable BOOLEAN typed columns
Date Mon, 28 Jun 2010 13:52:51 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rick Hillegas updated DERBY-4716:
---------------------------------

    Attachment: derby-4716-02-aa-indexOrder.diff

Attaching derby-4716-02-aa-indexOrder.diff. This corrects the sort order of null for indexed
BOOLEANs, making that order agree with the sort order of unindexed BOOLEANs and other indexed
types. I am running tests now.

Touches the following files:

---------

M      java/engine/org/apache/derby/iapi/types/SQLBoolean.java

There is a table of comments in both SQLBoolean.compare(DataValueDescriptor other) and NumberDataType.compare(DataValueDescriptor
other). The final column in each table states the semantics of how the methods should behave.
That final column agrees in both methods. However, the two comment blocks disagree on what
actual return value enforces those semantics. The SQLBoolean values are the opposite of those
in NumberDataValue both in the comments and in the subsequent implementation. I simply made
the comments and implementation of SQLBoolean.compare(DataValueDescriptor other) agree with
NumberDataType.compare(DataValueDescriptor other).

---------

M      java/testing/org/apache/derbyTesting/functionTests/tests/lang/BooleanValuesTest.java

Added a regression test case for this change.


> Enable BOOLEAN typed columns
> ----------------------------
>
>                 Key: DERBY-4716
>                 URL: https://issues.apache.org/jira/browse/DERBY-4716
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.6.1.0
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: derby-4716-01-ab-enableBooleanColumns.diff, derby-4716-02-aa-indexOrder.diff
>
>
> Allow tables to have boolean columns.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message