db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4706) Remove stale and potentially unused code Request.writeEncryptedScalarStream
Date Mon, 21 Jun 2010 13:16:26 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kristian Waagan updated DERBY-4706:
-----------------------------------

    Attachment: derby-4706-1a-remove_writeEncryptedScalarStream_and_friends.diff

Attached patch 1a, which removes a number of methods in Request.
The patch also makes the client driver throw an exception in case the code path is enabled.
Note that though the auxiliary methods are okay (and can be revived if required), the method
writeEncryptedScalarStream should be reimplemented if the functionality is needed.

Committed to trunk with revision 956569.

> Remove stale and potentially unused code Request.writeEncryptedScalarStream
> ---------------------------------------------------------------------------
>
>                 Key: DERBY-4706
>                 URL: https://issues.apache.org/jira/browse/DERBY-4706
>             Project: Derby
>          Issue Type: Task
>          Components: Network Client
>    Affects Versions: 10.7.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Trivial
>         Attachments: derby-4706-1a-remove_writeEncryptedScalarStream_and_friends.diff
>
>
> The code in net.Request.writeEncryptedScalarStream() is in a bad state, for instance:
>  - it materializes the stream
>  - it doesn't support streams longer than Integer.MAX_VALUE
>    (this is fine for BLOB since Derby limits the LOB size to 2G-1, but for CLOBs the
data stream may be longer since the length is expressed in characters)
>  - in some error situations it causes a disconnect
> Since the security mechanisms required to run this code (SECMEC_EUSRIDDTA and  SECMEC_EUSRPWDDTA)
are apparently supported in the client but not in the network server, deleting it seems like
a good option considering its state.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message