db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4613) Make client driver treat BOOLEAN columns the same way as the embedded driver does.
Date Mon, 10 May 2010 19:38:29 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rick Hillegas updated DERBY-4613:
---------------------------------

    Attachment: derby-4613-01-ab-correctBehavior.diff

Attaching derby-4613-01-ab-correctBehavior.diff. This patch implements the behavior described
in the functional spec attached to this issue.  This makes the embedded and network drivers
treat BOOLEAN values identically provided that both the client and the server are Derby code
at version 10.7 or higher. Regression tests passed cleanly for me. Compatibility tests need
to be written to verify that clients and servers play well with down-rev partners.

Touches the following files:

-----------

M      java/engine/org/apache/derby/iapi/reference/DRDAConstants.java

Exposes the DRDA and DB2 constants for the BOOLEAN datatype, as described in table 5-11 of
section 5.7 (FD:OCA Meta Data Summary) of Volume 1 of version 4 of the DRDA spec.


-----------

M      java/drda/org/apache/derby/impl/drda/AppRequester.java

Server-side logic for determining whether the client-side of the connection is at 10.7 or
higher.


-----------

M      java/drda/org/apache/derby/impl/drda/FdocaConstants.java
M      java/drda/org/apache/derby/impl/drda/SQLTypes.java
M      java/drda/org/apache/derby/impl/drda/DRDAConnThread.java

Server-side logic for sending BOOLEAN values and their corresponding metadata.


-----------

M      java/client/org/apache/derby/client/net/NetConnection.java
M      java/client/org/apache/derby/client/net/NetDatabaseMetaData.java
M      java/client/org/apache/derby/client/am/DatabaseMetaData.java

Client-side logic determining whether the server-side of a connection is at 10.7 or higher.
I found that I needed this logic in the abstract am package. While I was in there, I moved
a number of similar methods out of the concrete net package up into the abstract am package.
Ultimately, I think that the am package should be eliminated. See DERBY-4648.


-----------

M      java/client/org/apache/derby/client/net/Typdef.java
M      java/client/org/apache/derby/client/net/NetStatementRequest.java
M      java/client/org/apache/derby/client/am/Cursor.java
M      java/client/org/apache/derby/client/am/Types.java
M      java/client/org/apache/derby/client/am/SignedBinary.java
M      java/client/org/apache/derby/client/am/ColumnMetaData.java

Client-side logic for reading BOOLEAN values and their corresponding metadata.


-----------

M      java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java
M      java/testing/org/apache/derbyTesting/functionTests/master/showindex_client.out

Changes to the tests to reflect the new behavior of the network client.


> Make client driver treat BOOLEAN columns the same way as the embedded driver does.
> ----------------------------------------------------------------------------------
>
>                 Key: DERBY-4613
>                 URL: https://issues.apache.org/jira/browse/DERBY-4613
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.6.1.0
>            Reporter: Rick Hillegas
>         Attachments: derby-4613-01-ab-correctBehavior.diff, derby-4613-fs.html
>
>
> The only operation currently allowed on BOOLEAN columns is to select them from the system
tables. For instance, the following query selects BOOLEAN values:
>     select systemalias from sys.sysaliases;
> There are discrepancies in how the embedded and client drivers handle these BOOLEAN columns.
The embedded behavior is correct and the client behavior should conform. I will attach a spec
describing what needs to be done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message