db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4608) Unnecessary conversion of binary values to strings in SQLBinary.compare()
Date Tue, 06 Apr 2010 14:10:33 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853985#action_12853985
] 

Bryan Pendleton commented on DERBY-4608:
----------------------------------------

The patch looks good to me, thanks for tracking this down.

I don't particularly care for the wording of the THROWASSERT
in SQLBinary.java just prior to your change, but of course that's
entirely unrelated, just something that struck my eye while
reading your patch.

+1 to your patch, which looks thorough and complete.


> Unnecessary conversion of binary values to strings in SQLBinary.compare()
> -------------------------------------------------------------------------
>
>                 Key: DERBY-4608
>                 URL: https://issues.apache.org/jira/browse/DERBY-4608
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.5.3.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>         Attachments: isnull.diff
>
>
> SQLBinary.compare(int,DataValueDescriptor,boolean,boolean) converts the values to strings
in order to check whether any of them are null. The isNull() method should be used instead
to prevent the unnecessary conversion to strings.
> See this thread on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/201003.mbox/%3C001801cad09b$09aef650$1d0ce2f0$@ru%3E

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message