db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2602) TIMESTAMP value is truncated when return to client
Date Tue, 13 Apr 2010 12:12:51 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856399#action_12856399
] 

Knut Anders Hatlen commented on DERBY-2602:
-------------------------------------------

The patch looks fine to me. I only have two minor comments:

1) The other serverSupports* helper methods are located in NetConnection instead of NetAgent.
I think moving serverSupportsTimestampNanoseconds() over there as well would give the following
benefits:

    a) no need to allocate a new NetDatabaseMetaData object and cache it in NetAgent, since
NetConnection already has a cached instance

    b) no need to expose NetConnection.newDatabaseMetaData_() as a public method

2) Some of the lines exceed the 80 characters limit

> TIMESTAMP value is truncated  when return to client
> ---------------------------------------------------
>
>                 Key: DERBY-2602
>                 URL: https://issues.apache.org/jira/browse/DERBY-2602
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client
>    Affects Versions: 10.3.1.4
>            Reporter: Kathey Marsden
>            Assignee: Rick Hillegas
>            Priority: Minor
>         Attachments: d2602.java, derby-2602-01-ad-dontTruncate.diff
>
>
> In ParameterMappingTest   I see the following differences between embedded and client.
 Client is truncating the TIMESTAMP value.  Look for this bug number in the test for reproduction.
>  case java.sql.Types.TIMESTAMP:
>             if (param == 2)
>                 if (usingEmbedded())
>                     assertEquals("2004-03-12 21:14:24.938222433", val.toString());
>                 else
>                     assertEquals("2004-03-12 21:14:24.938222", val.toString());
>             else if (param == 3)
>                 if (usingEmbedded())
>                     assertEquals("2004-04-12 04:25:26.462983731", val.toString());
>                 else
>                     assertEquals("2004-04-12 04:25:26.462983", val.toString());
>             break; 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message