db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4509) Convert autoincrement.sql to JUnit
Date Wed, 24 Mar 2010 17:19:27 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849288#action_12849288
] 

Kathey Marsden commented on DERBY-4509:
---------------------------------------

I looked at the autoincrement_March162010.txt  patch and it looks good except that there seem
to be some extra commented out statements that should be removed, e.g as I think they must
be something superfluous from your work converting the test e.g after //-with unique index
you have.

		//s.execute("insert into uniquet4(i) values(3)");
		//s.execute("insert into uniquet4(i) values(4)");
		//s.execute("insert into uniquet4(i) values(5)");		
		//assertStatementError("23505",s,"insert into uniquet4(i,uniquet4_autogen) values(1,0)");
		//assertStatementError("23505",s,"insert into uniquet4(i,uniquet4_autogen) values(1,0)");
		
Please remove those and post a new patch and I will commit it.  I will be out next week, so
hopefully you can do this today or tomorrow.

After commit,  It might be nice too as extra credit, to  make an additional patch in which
you add javadoc comments to the fixtures.  In Eclipse, you can just click on the method name
and then right click -> Source -> Generate element comment and then add a brief comment
of what the fixture is testing, just to make things tidy, but first just remove the superfluous
commented code and then follow up with this if you want to.



> Convert autoincrement.sql to JUnit
> ----------------------------------
>
>                 Key: DERBY-4509
>                 URL: https://issues.apache.org/jira/browse/DERBY-4509
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>         Environment: Apache Derby
>            Reporter: Jayaram Subramanian
>            Assignee: Jayaram Subramanian
>            Priority: Minor
>         Attachments: autoincrement_March162010.txt, AutoIncrementDO-NOT_COMMIT_diff.txt,
AutoIncrementDO_NOT_COMMIT_diff.txt, AutoIncrementDO_NOT_COMMIT_diff.txt, AutoIncrementrevised.txt,
jira4509.txt, jira4509feb4.txt, jira4509feb4stat.txt, jira4509stat.txt, stat_March162010.txt,
statrevised.txt
>
>
> The task is to convert existing autoincrement.sql to JUnit

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message