db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Closed: (DERBY-4600) Use ValueNodeList helper methods in CoalesceFunctionNode
Date Mon, 29 Mar 2010 08:57:27 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen closed DERBY-4600.

          Resolution: Fixed
       Fix Version/s:
    Issue & fix info:   (was: [Patch Available])

Committed revision 928649.

> Use ValueNodeList helper methods in CoalesceFunctionNode
> --------------------------------------------------------
>                 Key: DERBY-4600
>                 URL: https://issues.apache.org/jira/browse/DERBY-4600
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions:
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>             Fix For:
>         Attachments: helpers.diff
> CoalesceFunctionNode manually iterates over argumentsList (a ValueNodeList) in acceptChildren(),
preprocess(), remapColumnReferencesToExpressions() and isEquivalent(). ValueNodeList has helper
methods for the first three of those, and those helper methods should be used instead to simplify
the code. There is no helper method for isEquivalent(), but since very similar code is also
found in the isEquivalent() methods of BinaryListOperatorNode and ConditionalNode, we should
add a new helper and use it in those classes too.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message