db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4600) Use ValueNodeList helper methods in CoalesceFunctionNode
Date Fri, 26 Mar 2010 07:58:27 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-4600:

    Attachment: helpers.diff

Attaching a patch that makes CoalesceFunctionNode use helper methods instead of iterating
over argumentsList manually. It also adds a new method isEquivalent() to ValueNodeList and
uses it in BinaryListOperatorNode, CoalesceFunctionNode and ConditionalNode.

All the regression tests ran cleanly with the patch.

> Use ValueNodeList helper methods in CoalesceFunctionNode
> --------------------------------------------------------
>                 Key: DERBY-4600
>                 URL: https://issues.apache.org/jira/browse/DERBY-4600
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions:
>            Reporter: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: helpers.diff
> CoalesceFunctionNode manually iterates over argumentsList (a ValueNodeList) in acceptChildren(),
preprocess(), remapColumnReferencesToExpressions() and isEquivalent(). ValueNodeList has helper
methods for the first three of those, and those helper methods should be used instead to simplify
the code. There is no helper method for isEquivalent(), but since very similar code is also
found in the isEquivalent() methods of BinaryListOperatorNode and ConditionalNode, we should
add a new helper and use it in those classes too.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message