db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Closed: (DERBY-1347) derbynet/SuicideOfStreaming.java should not use internal class SqlCode
Date Wed, 10 Mar 2010 11:25:27 GMT

     [ https://issues.apache.org/jira/browse/DERBY-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen closed DERBY-1347.

    Resolution: Duplicate

This problem was fixed when the test was rewritten to JUnit in DERBY-2054. Closing as duplicate.

> derbynet/SuicideOfStreaming.java should not use internal class SqlCode
> ----------------------------------------------------------------------
>                 Key: DERBY-1347
>                 URL: https://issues.apache.org/jira/browse/DERBY-1347
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>            Reporter: David Van Couvering
>            Priority: Minor
> In the method examineExpectedInDerbyNetClient, the code validates the error code using
the following:
> 	return 
> 	    sqlex.getSQLState().equals("08006") && 
> 	    sqlex.getErrorCode() == SqlCode.disconnectError.getCode();
> SqlCode is an internal class and our tests shouldn't rely on it.  We should probably
just use the error code explicitly, or define a testing class that contains some of the error
codes that Derby returns.
> Also: are our error codes even a documented public interface?

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message