db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Leroux (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4561) Help in ij should fit in 80 columns terminal
Date Mon, 15 Mar 2010 09:41:27 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845256#action_12845256
] 

Sylvain Leroux commented on DERBY-4561:
---------------------------------------

Hi Denis,

Thanks for your work. I have a couple of issues though:
(1) The help messages should follow the SQL convention for comments. Comment are introduced
by a double-dash which should be repeated if the comment span multiple lines. Here is an example:
  RELATIVE integer name;       -- positions the named scroll cursor relative to
                               -- the current row

(2) It appears that the patch does not pass the 'derbytools' test suite:
  sh$ ant all && java org.apache.derbyTesting.functionTests.harness.RunSuite derbytools
  sh$ cat derbytools_fail.txt 
  derbytools/derbytools.fail:tools/ij.sql
  derbytools/derbytools.fail:tools/ij.sql

See in derbytools_report.txt for the details.

(3) This one is only a matter of taste, but could we split at character 78 or 79 instead of
80? I don't find very elegant when words end right on the scrollbar.


Once again, thank you for working on that,
- Sylvain.

> Help in ij should fit in 80 columns terminal
> --------------------------------------------
>
>                 Key: DERBY-4561
>                 URL: https://issues.apache.org/jira/browse/DERBY-4561
>             Project: Derby
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Sylvain Leroux
>            Priority: Trivial
>         Attachments: derby-4561-patch-1.diff
>
>
> In ij, some statements seem to assume 80 columns terminal to format their output (SHOW
FUNCTION, SHOW PROCEDURE).
> But not HELP.
> HELP should assume the same defaults in order to fit nicely in 80 columns terminal. An
other option would be to dynamically adjust the display to the real terminal width - but I
don't know if there is a portable way of doing this in Java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message