db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Closed: (DERBY-4512) Avoid unnecessary lookup in transaction table when adding transaction
Date Tue, 19 Jan 2010 09:58:54 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen closed DERBY-4512.

          Resolution: Fixed
       Fix Version/s:
    Issue & fix info:   (was: [Patch Available])

Committed revision 900714.

> Avoid unnecessary lookup in transaction table when adding transaction
> ---------------------------------------------------------------------
>                 Key: DERBY-4512
>                 URL: https://issues.apache.org/jira/browse/DERBY-4512
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>    Affects Versions:
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>             Fix For:
>         Attachments: assert.diff, txtab-noblanks.diff, txtab.diff
> TransactionTable.add() first checks if the Hashtable trans contains a transaction with
the same id as the one being added. If it does, add() does nothing. If there is no such transaction,
a new TransactionTableEntry is created and put into the Hashtable.
> I believe that TransactionTable.add() is never called on a transaction that has already
been added to the table. If this is the case, there's no point in checking the Hashtable first.
Instead, we could just create a new TransactionTableEntry and add it unconditionally. This
would reduce the number of (synchronized) Hashtable calls and could improve the performance
in scenarios like the one described in DERBY-3092.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message