Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 19739 invoked from network); 4 Dec 2009 00:45:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 Dec 2009 00:45:43 -0000 Received: (qmail 64264 invoked by uid 500); 4 Dec 2009 00:45:43 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 64210 invoked by uid 500); 4 Dec 2009 00:45:43 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 64202 invoked by uid 99); 4 Dec 2009 00:45:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Dec 2009 00:45:43 +0000 X-ASF-Spam-Status: No, hits=-10.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Dec 2009 00:45:40 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A1170234C045 for ; Thu, 3 Dec 2009 16:45:20 -0800 (PST) Message-ID: <430284307.1259887520644.JavaMail.jira@brutus> Date: Fri, 4 Dec 2009 00:45:20 +0000 (UTC) From: "Bryan Pendleton (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Resolved: (DERBY-4293) Mutable public static variables In-Reply-To: <173705591.1246146767427.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton resolved DERBY-4293. ------------------------------------ Resolution: Fixed Fix Version/s: 10.6.0.0 Assignee: Knut Anders Hatlen Marked as resolved. I believe Knut committed both patches successfully. > Mutable public static variables > ------------------------------- > > Key: DERBY-4293 > URL: https://issues.apache.org/jira/browse/DERBY-4293 > Project: Derby > Issue Type: Improvement > Components: Build tools, Network Client, SQL, Store > Affects Versions: 10.6.0.0 > Reporter: Sebb > Assignee: Knut Anders Hatlen > Fix For: 10.6.0.0 > > Attachments: derbyfinal.patch, derbyfinal2.patch > > > There are quite a few instances of public static fields which appear to be intended to be constant, but which are not final. > The code would be safer if all the constant fields were made final. > Patch to follow for some of the problem fields. > The following also ought to be fixed: > org.apache.derby.iapi.services.property.PropertyUtil.servicePropertyList (e.g. use an accessor to lookup the values) > org.apache.derby.iapi.types.JSQLType.primitiveNames (ditto) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.