db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4472) [patch] non short circuit op, could cause eof problems
Date Mon, 14 Dec 2009 08:20:20 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790034#action_12790034
] 

Kristian Waagan commented on DERBY-4472:
----------------------------------------

Hi Dave,

Thank you for contributing patches to Derby.
I had look at the patch, and the change looks good.
Shouldn't the other occurrence of this problem, in the same class, be fixed too?


FYI: If you plan to contribute larger patches to Derby, you should consider filling in a CLA
(contributer license agreement) and send it to the ASF. See http://www.apache.org/licenses/
or http://wiki.apache.org/db-derby/DerbyContributorChecklist.

> [patch] non short circuit op, could cause eof problems
> ------------------------------------------------------
>
>                 Key: DERBY-4472
>                 URL: https://issues.apache.org/jira/browse/DERBY-4472
>             Project: Derby
>          Issue Type: Bug
>          Components: JDBC
>    Affects Versions: 10.5.3.0
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: sc.diff
>
>
> (from patch)
>          int offset = 0;
> -        while( offset < dataDirectory.length() & Character.isSpaceChar( dataDirectory.charAt(
offset)))
> +        while( offset < dataDirectory.length() && Character.isSpaceChar(
dataDirectory.charAt( offset)))
>              offset ++;
>          int leftParen = -1;
>          int rightParen = -1;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message