db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4424) Convert outerjoin.sql into JUnit
Date Sat, 14 Nov 2009 10:11:39 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777865#action_12777865

Knut Anders Hatlen commented on DERBY-4424:

Does anyone know what this warning is supposed to tell us?

One small concern I have with the patch, is that I'm not sure it preserves the intention of
the runtime statistics tests. The new test only checks that the plans contained a table scan
and did not contain a distinct scan. The comments in the original test seem to indicate that
the intention was to test certain properties of the predicates. Unfortunately, it's difficult
to know exactly which properties of the predicates to check, since the comments are rather
vague. One of the comments is more specific, though, and says "make sure predicates are null
tolerant", but the new test only checks the results from the query. I think "null tolerant"
means we should check that the predicates have the property "Ordered nulls: false".

> Convert outerjoin.sql into JUnit
> --------------------------------
>                 Key: DERBY-4424
>                 URL: https://issues.apache.org/jira/browse/DERBY-4424
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For:
>         Attachments: OuterJoinTest.diff
> Conversion of the outerjoin test into JUnit

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message