db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4442) Evaluation of default value and identity in an INSERT result set evaluated too early.
Date Fri, 27 Nov 2009 15:34:20 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen updated DERBY-4442:
--------------------------------------

    Attachment: d4442-1b.diff

Here's a new revision of the patch (1b) with one small change:

The comment in InsertNode.enhanceAndCheckForAutoincrement() only explained why it was OK to
skip the call to forbidOverrides() on the top-level RCL for a multi-row table constructor.
Now it also explains why it *should* be skipped, to make it clear that the check is actually
needed and not some kind of optimization.

> Evaluation of default value and identity in an INSERT result set evaluated too early.
> -------------------------------------------------------------------------------------
>
>                 Key: DERBY-4442
>                 URL: https://issues.apache.org/jira/browse/DERBY-4442
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>            Reporter: Dag H. Wanvik
>            Assignee: Knut Anders Hatlen
>         Attachments: always_prn.diff, d4442-1a.diff, d4442-1a.stat, d4442-1b.diff, insert.diff
>
>
> In contrast to generated column, which are evaluated when the next row from the result
set to be inserted, currently default values and identity columns are generated "early", that
is as part of avaluating the subquery (SELECT or VALUES as the case may be). 
> This does not currently cause a user visible bug in Derby, but it lies behind DERBY-3
and the effect Bryan observed in DERBY-4.
> Additionally, "early" computation has given rise to much special handling and ensuing
bugs, cf. DERBY-1644, DERBY-4413, DERBY-4419, DERBY-4425 and others.
> DERBY-4397 requires this fix for correct behaviour with INSERT.
> See also
> https://issues.apache.org/jira/browse/DERBY-4413?focusedCommentId=12769532&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12769532

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message